AlanConfluent commented on code in PR #26567:
URL: https://github.com/apache/flink/pull/26567#discussion_r2150524669
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/config/ExecutionConfigOptions.java:
##########
@@ -456,6 +456,49 @@ public class ExecutionConfigOptions {
"The max number of async retry attempts to make
before task "
+ "execution is failed.");
+ // ------------------------------------------------------------------------
+ // Async Table Function
+ // ------------------------------------------------------------------------
+ @Documentation.TableOption(execMode = Documentation.ExecMode.STREAMING)
+ public static final ConfigOption<Integer>
TABLE_EXEC_ASYNC_TABLE_MAX_CONCURRENT_OPERATIONS =
+ key("table.exec.async-table.max-concurrent-operations")
Review Comment:
> Admittedly, changing the config name here causes the inconsistent config
name in AsyncScalarFunction. We can add the new config key and change the old
config keys as deprecated config key.
Should I do that as part of this PR or have a followup for
`AsyncScalarFunction`?
> Another thing is that at this point, our design principle for configs in
SQL seems not consistent. Some of the configs are set using hints, while others
are in the execution config. It would be good to have a common design
principle, so users don't need to guess how to config the physical behaviors.
I agree. It's a bit inconsistent. I think all async operations (scalar,
table, lookup joins, ml_predict) support the execution config, though only
lookup joins at the moment also support hints. Hints support could certainly
be added in the future to others. I can file jiras for each feature to add
hint support, if it can be retro actively added to old FLIPs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
