fsk119 commented on code in PR #26644:
URL: https://github.com/apache/flink/pull/26644#discussion_r2148937572
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/sql/ml/SqlMLPredictTableFunction.java:
##########
@@ -134,100 +123,13 @@ public SqlOperandCountRange getOperandCountRange() {
@Override
public boolean isOptional(int i) {
- return i > getOperandCountRange().getMin() && i <=
getOperandCountRange().getMax();
+ return i >= getOperandCountRange().getMin() && i <=
getOperandCountRange().getMax();
Review Comment:
Calctie uses 0 to indicate the first operand here. It's better we can add a
case to prevent other break this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
