Re: [PR] [FLINK-37799][model] Support OpenAI Model Function [flink]

[via GitHub]

yunfengzhou-hub commented on code in PR #26652:
URL: https://github.com/apache/flink/pull/26652#discussion_r2148897320


##########
flink-core/src/main/java/org/apache/flink/configuration/GlobalConfiguration.java:
##########
@@ -52,6 +52,7 @@ public final class GlobalConfiguration {
                 "secret",
                 "fs.azure.account.key",
                 "apikey",
+                "api-key",

Review Comment:
   According to previous comments with @fsk119, existing practices about Model 
Function have used `api-key` instead of `apikey`, so the same convention is 
also followed here.
   
![](https://private-user-images.githubusercontent.com/33114724/453798492-5cf0363a-f0b9-4a46-8cd2-ba4f5bc7ab85.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NTAwMzQ1MDksIm5iZiI6MTc1MDAzNDIwOSwicGF0aCI6Ii8zMzExNDcyNC80NTM3OTg0OTItNWNmMDM2M2EtZjBiOS00YTQ2LThjZDItYmE0ZjViYzdhYjg1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA2MTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNjE2VDAwMzY0OVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTQ0YTBmMzBhNGIzMzhiYTBkZDVhNzQ1MTNiMTAyOWZjM2VkMDI1Y2U2NzJiNmVhMTU0MGRlMjNhMDg2YmE0NTYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.DwoDCX9o5cKsUVk1FDH9YIBBssvxwOFYA5LtAZYc4ic)
   https://trino.io/docs/current/functions/ai.html
   
   As for `apikey`, it seems that it is used in `DatadogHttpReporterFactory`, a 
custom metric reporter. Given that both these configurations are defined by 
Flink plugins rather than Flink core, it should be OK that they do not follow 
the same rule.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org