mxm commented on code in PR #26640:
URL: https://github.com/apache/flink/pull/26640#discussion_r2145469373
##########
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/state/rocksdb/RocksDBStateUploader.java:
##########
@@ -180,6 +190,19 @@ private HandleAndLocalPath uploadLocalFileToCheckpointFs(
}
}
+ @VisibleForTesting
+ void applyJitter(Supplier<Long> sleepTime) throws InterruptedException {
Review Comment:
You are never actually using this parameter to pass in something else. I
think passing in `Consumer<Long>` and using `sleepTime ->
Thread.sleep(sleepTime)` by default would make more sense. You can then pass in
a different Consumer in the tests, e.g. `sleepTime ->
assertThat(sleepTime).isEqualTo(..)`.
##########
flink-state-backends/flink-statebackend-rocksdb/src/test/java/org/apache/flink/state/rocksdb/RocksDBStateUploaderTest.java:
##########
@@ -51,6 +52,7 @@
import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.assertThatThrownBy;
+import static
org.testcontainers.shaded.org.bouncycastle.oer.its.ieee1609dot2.basetypes.Duration.milliseconds;
Review Comment:
Check this import please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
