Izeren commented on PR #26663: URL: https://github.com/apache/flink/pull/26663#issuecomment-2970825365
> * We should add test case to AdaptiveScheduler with custom implementation of SlotAssigner that acts as a regression test > * We should add test case to SlotAssigner implementation that verifies how SA behaves in non-rescaling scenarios, when we simply want to reuse previously known allocations @dmvk, I have added 2 tests: 1. For `AdaptiveScheduler` to ensure that `SlotAllocator` receives data from the checkpoint and will use it for distribution. (I couldn't check the checkpoints themselves as it AllocationInformation calculated through static call, hence I verify that state made it into SlotAllocator after). 2. For `SlotAllocator` to ensure that it preserves allocation according to state distribution and should retain allocation for a job restart. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
