xuyangzhong commented on code in PR #26632:
URL: https://github.com/apache/flink/pull/26632#discussion_r2139674711
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/descriptors/DescriptorProperties.java:
##########
@@ -112,6 +112,12 @@ public class DescriptorProperties {
public static final String PRIMARY_KEY_COLUMNS = "primary-key.columns";
+ public static final String INDEX = "index";
+
+ public static final String INDEX_NAME = "index-name";
Review Comment:
nit: follow the format with primary key:
```
index.name
index.columns
```
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/CatalogPropertiesUtil.java:
##########
@@ -382,6 +382,12 @@ public static CatalogModel
deserializeCatalogModel(Map<String, String> propertie
private static final String PRIMARY_KEY_COLUMNS = compoundKey(PRIMARY_KEY,
COLUMNS);
+ private static final String INDEX = "index";
+
+ private static final String INDEX_NAME = "index-name";
Review Comment:
use `compoundKey(INDEX, NAME)`
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/CatalogPropertiesUtil.java:
##########
@@ -382,6 +382,12 @@ public static CatalogModel
deserializeCatalogModel(Map<String, String> propertie
private static final String PRIMARY_KEY_COLUMNS = compoundKey(PRIMARY_KEY,
COLUMNS);
+ private static final String INDEX = "index";
+
+ private static final String INDEX_NAME = "index-name";
+
+ private static final String INDEX_COLUMNS = "index-columns";
Review Comment:
use `compoundKey(INDEX, COLUMNS)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
