xuyangzhong commented on PR #26648: URL: https://github.com/apache/flink/pull/26648#issuecomment-2961326934
Hi, @lincoln-lil. 1. The trait itself does not affect the generation of the plan or cause compilation errors when the trait is not satisfied. It simply attaches information to each node from the sink to the source. For the case where the delta join configuration is set to FORCE, I will introduce a checking resolver in StreamCommonSubGraphBasedOptimizer#postOptimize to throw an exception if necessary. 2. Since strong consistency does not produce redundant data, there is no need to check the DuplicateChangesTrait. Only delta joins with eventual consistency semantics need to check the DuplicateChangesTrait to determine whether a regular join can be converted into a delta join. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
