fsk119 commented on PR #26653: URL: https://github.com/apache/flink/pull/26653#issuecomment-2954785112
> The constant FIELD_NAME_CAPACITY contains a trailing space. Consider removing the extra space (i.e., use "capacity") to avoid potential misalignments or serialization issues It may influence planner to restore from the json. Leave this unchanged. > The name 'Variable' is very generic, which may lead to confusion about its purpose. Consider renaming it to something more descriptive like 'LookupVariable' to better convey the intent. LookupVariable is not suitable for this case because ML_PREDICT doesn't use lookup semantic. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
