darenwkt commented on PR #22: URL: https://github.com/apache/flink-connector-prometheus/pull/22#issuecomment-2953691241
Hi @georgelza , > Is sink.batch.max-size and sink.flush-buffer.size part of the current build. Can I clarify on your question please? Do you mean if the current TableAPI connector implementation allows user to configure their own `sink.batch.max-size` and `sink.flush-buffer.size`? > I noticed metric.name needs to map to a column in the table, I will argue that this is not desirable... you might have multiple tables being that will push to the prometheus store. based on the table being used the user will want to define a text string as the name of the metrics contained... In the Datastream API connector, we allow PrometheusSink to submit to different MetricName according to what is set in TimeSeries. Hence, the TableAPI connector is consistent in this regard as well. https://nightlies.apache.org/flink/flink-docs-master/docs/connectors/datastream/prometheus/#populating-a-prometheustimeseries -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
