fsk119 commented on PR #26630: URL: https://github.com/apache/flink/pull/26630#issuecomment-2942937506
> @fsk119 Please could you write down in the Flip or the Jira the motivation for reusing the lookupJoin operator for the ML_PREDICT. I am curious what the join key means for ML_PREDICT. Does this mean that there always has to be something to join on in order to be able to issue the ML_PREDICT call? Hi @davidradl. Thanks a lot for your suggestions. I share my thoughts about the reusing: 1. Operator is very internal to users, reuse or not reuse will not influence users to use Flink build ML pipelines. 2. The most codes in the operator codegen or the runner utils are similar. If we introduce a new util about this, it may take a lot of time to finish the remaining work. Considering our time is limited(code freezeing time is coming), a lot of work need to be done. I think we can refactor this part when most of features are finished. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
