Au-Miner commented on code in PR #26632:
URL: https://github.com/apache/flink/pull/26632#discussion_r2127816115
##########
flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/catalog/SchemaResolutionTest.java:
##########
@@ -304,6 +308,44 @@ void testSchemaResolutionErrors() {
testError(
Schema.newBuilder().column("id",
DataTypes.INT()).primaryKey("id", "id").build(),
"Invalid primary key 'PK_id_id'. A primary key must not
contain duplicate columns. Found: [id]");
+
Review Comment:
testError(
Schema.newBuilder().column("id",
DataTypes.INT()).primaryKey("INVALID").build(),
"Column 'INVALID' does not exist.");
This section has already been validated with similar tests.
##########
flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/catalog/SchemaResolutionTest.java:
##########
@@ -304,6 +308,44 @@ void testSchemaResolutionErrors() {
testError(
Schema.newBuilder().column("id",
DataTypes.INT()).primaryKey("id", "id").build(),
"Invalid primary key 'PK_id_id'. A primary key must not
contain duplicate columns. Found: [id]");
+
Review Comment:
> can we test with column names containing one or more "_" characters, maybe
a_b_c__d as a column name.
testError(
Schema.newBuilder().column("id",
DataTypes.INT()).primaryKey("INVALID").build(),
"Column 'INVALID' does not exist.");
This section has already been validated with similar tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
