davidradl commented on code in PR #26630:
URL: https://github.com/apache/flink/pull/26630#discussion_r2127025290
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/config/ExecutionConfigOptions.java:
##########
@@ -443,6 +443,36 @@ public class ExecutionConfigOptions {
"The max number of async retry attempts to make
before task "
+ "execution is failed.");
+ // ------------------------------------------------------------------------
+ // Async ML_PREDICT Options
+ // ------------------------------------------------------------------------
+
+ @Documentation.TableOption(execMode =
Documentation.ExecMode.BATCH_STREAMING)
+ public static final ConfigOption<Integer>
TABLE_EXEC_ASYNC_ML_PREDICT_BUFFER_CAPACITY =
+ key("table.exec.async-ml-predict.buffer-capacity")
+ .intType()
+ .defaultValue(100)
+ .withDescription(
+ "The max number of async i/o operation that the
async ml predict can trigger.");
+
+ @Documentation.TableOption(execMode =
Documentation.ExecMode.BATCH_STREAMING)
+ public static final ConfigOption<Duration>
TABLE_EXEC_ASYNC_ML_PREDICT_TIMEOUT =
+ key("table.exec.async-ml-predict.timeout")
+ .durationType()
+ .defaultValue(Duration.ofMinutes(3))
+ .withDescription(
+ "The async timeout for the asynchronous operation
to complete.");
+
+ @Documentation.TableOption(execMode =
Documentation.ExecMode.BATCH_STREAMING)
+ public static final ConfigOption<AsyncOutputMode>
TABLE_EXEC_ASYNC_ML_PREDICT_OUTPUT_MODE =
+ key("table.exec.async-ml-predict.output-mode")
+ .enumType(AsyncOutputMode.class)
+ .defaultValue(AsyncOutputMode.ALLOW_UNORDERED)
+ .withDescription(
+ "Output mode for asynchronous operations which
will convert to {@see AsyncDataStream.OutputMode}, ALLOW_UNORDERED by default. "
+ + "That is to say the planner will attempt
to use {@see AsyncDataStream.OutputMode.UNORDERED} when it does not "
+ + "affect the correctness of the result,
otherwise ORDERED will be still used.");
Review Comment:
I do not follow the description.
The first sentence is confusing. I suggest something like
Output mode for async ML predict, which describes whether or not the the
output should attempt to be ordered or not. The supported options are:
ALLOW_UNORDERED which means ... The planner will attempt use unordered ....
This is the default.
ALLOW_ORDERED which means ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
