xuyangzhong commented on code in PR #25932:
URL: https://github.com/apache/flink/pull/25932#discussion_r2125410525
##########
flink-table/flink-table-planner/src/test/resources/org/apache/flink/table/planner/plan/stream/sql/join/WindowJoinTest.xml:
##########
@@ -199,35 +199,19 @@
LogicalSink(table=[default_catalog.default_database.sink2], fields=[window_start
<![CDATA[
Sink(table=[default_catalog.default_database.sink1], fields=[window_start,
window_end, user_id, dt, hour])
+- Calc(select=[window_start, window_end, user_id, DATE_FORMAT(+(window_end,
25200000:INTERVAL HOUR), 'yyyyMMdd') AS dt, DATE_FORMAT(+(window_end,
25200000:INTERVAL HOUR), 'HH') AS hour])
- +- WindowJoin(leftWindow=[TUMBLE(win_start=[window_start],
win_end=[window_end], size=[1 min])],
rightWindow=[TUMBLE(win_start=[window_start], win_end=[window_end], size=[1
min])], joinType=[LeftOuterJoin], where=[=(user_id, user_id0)],
select=[user_id, window_start, window_end, user_id0, window_start0,
window_end0])
- :- Exchange(distribution=[hash[user_id]])
- : +- GlobalWindowAggregate(groupBy=[user_id],
window=[TUMBLE(slice_end=[$slice_end], size=[1 min])], select=[user_id,
start('w$) AS window_start, end('w$) AS window_end])
- : +- Exchange(distribution=[hash[user_id]])
- : +- LocalWindowAggregate(groupBy=[user_id],
window=[TUMBLE(time_col=[event_time], size=[1 min])], select=[user_id,
slice_end('w$) AS $slice_end])
- : +- WatermarkAssigner(rowtime=[event_time],
watermark=[event_time])
- : +- TableSourceScan(table=[[default_catalog,
default_database, food_order, project=[user_id, event_time], metadata=[]]],
fields=[user_id, event_time])
+ +- GlobalWindowAggregate(groupBy=[user_id],
window=[TUMBLE(slice_end=[$slice_end], size=[1 min])], select=[user_id,
start('w$) AS window_start, end('w$) AS window_end])
Review Comment:
I believe we should make some minor adjustments to this test, as it was
primarily designed to test the combination of window joins and global window
aggregations in a multi-sink context. I want to ensure that the current changes
do not compromise the validity of this test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
