darenwkt commented on code in PR #22:
URL:
https://github.com/apache/flink-connector-prometheus/pull/22#discussion_r2121085993
##########
flink-connector-prometheus-request-signer-amp/src/main/java/org/apache/flink/connector/prometheus/sink/aws/AmazonManagedPrometheusWriteRequestSignerFactory.java:
##########
@@ -0,0 +1,36 @@
+package org.apache.flink.connector.prometheus.sink.aws;
+
+import org.apache.flink.connector.prometheus.sink.PrometheusRequestSigner;
+import org.apache.flink.connector.prometheus.table.PrometheusConfig;
+import
org.apache.flink.connector.prometheus.table.PrometheusDynamicRequestSignerFactory;
+
+import java.util.regex.Matcher;
+import java.util.regex.Pattern;
+
+public class AmazonManagedPrometheusWriteRequestSignerFactory
Review Comment:
Request signer is now a plugin (through Java Service Provider Interface
(SPI)), and can be specified by user in the table config
(`metric.request-signer`), for example:
```
CREATE TABLE PromTable (
`my_metric_name` BIGINT,
`my_label` BIGINT,
`sample_value` BIGINT,
`sample_ts` TIMESTAMP(3)
)
WITH (
'connector' = 'prometheus',
'aws.region' = 'us-east-1',
'metric.request-signer' = 'amazon-managed-prometheus',
'metric.endpoint-url' =
'https://aps-workspaces.us-east-1.amazonaws.com/workspaces/abc',
'metric.name' = 'my_metric_name',
'metric.label.keys' = '[my_label_1,my_label_2]',
'metric.sample.key' = 'sample_value',
'metric.sample.timestamp' = 'sample_ts',
'sink.batch.max-size' = '2',
'sink.flush-buffer.size' = '1'
);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
