csviri commented on code in PR #982:
URL: 
https://github.com/apache/flink-kubernetes-operator/pull/982#discussion_r2120674243


##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/utils/EventSourceUtils.java:
##########
@@ -114,8 +115,8 @@ public static InformerEventSource<Deployment, 
FlinkDeployment> getDeploymentInfo
                                                 
flinkDeployment.getMetadata().getName(),
                                                 
flinkDeployment.getMetadata().getNamespace())));
 
-        InformerConfiguration<FlinkSessionJob> configuration =
-                InformerConfiguration.from(FlinkSessionJob.class, context)
+        var configuration =
+                InformerEventSourceConfiguration.from(FlinkSessionJob.class, 
FlinkSessionJob.class)

Review Comment:
   Actually not, it is just used for the default secondayr to primary mapper. 
So actually the API might be on JOSDK side. So this is not a mandatory field.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to