fsk119 commented on code in PR #26603: URL: https://github.com/apache/flink/pull/26603#discussion_r2113420207
########## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/calcite/RexModelCall.java: ########## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.planner.calcite; + +import org.apache.flink.table.planner.plan.schema.ModelProviderModel; + +import org.apache.calcite.rel.type.RelDataType; +import org.apache.calcite.rex.RexCall; +import org.apache.calcite.sql.SqlKind; +import org.apache.calcite.sql.SqlSpecialOperator; + +import java.util.List; + +/** + * A {@link RexCall} that represents a call to a model provider model. + * + * <p>This is used to represent calls to models in the Flink SQL planner. + */ +public class RexModelCall extends RexCall { + + private ModelProviderModel modelProviderModel; + private RelDataType inputType; Review Comment: Why we need input type? ########## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/calcite/RexModelCall.java: ########## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.planner.calcite; + +import org.apache.flink.table.planner.plan.schema.ModelProviderModel; + +import org.apache.calcite.rel.type.RelDataType; +import org.apache.calcite.rex.RexCall; +import org.apache.calcite.sql.SqlKind; +import org.apache.calcite.sql.SqlSpecialOperator; + +import java.util.List; + +/** + * A {@link RexCall} that represents a call to a model provider model. + * + * <p>This is used to represent calls to models in the Flink SQL planner. + */ +public class RexModelCall extends RexCall { Review Comment: I think you are right. ########## flink-table/flink-table-planner/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java: ########## @@ -5833,6 +5834,11 @@ public RexNode visit(SqlCall call) { // when converting to RexNode. validator().setValidatedNodeType(permutedCall, typeIfKnown); } + + if (permutedCall instanceof SqlModelCall) { Review Comment: I think it's better we can move these codes to `FlinkConvertletTable`, so we can reduce the cost when upgrading calcite. ########## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/calcite/RexModelCall.java: ########## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.planner.calcite; + +import org.apache.flink.table.planner.plan.schema.ModelProviderModel; + +import org.apache.calcite.rel.type.RelDataType; +import org.apache.calcite.rex.RexCall; +import org.apache.calcite.sql.SqlKind; +import org.apache.calcite.sql.SqlSpecialOperator; + +import java.util.List; + +/** + * A {@link RexCall} that represents a call to a model provider model. + * + * <p>This is used to represent calls to models in the Flink SQL planner. + */ +public class RexModelCall extends RexCall { + + private ModelProviderModel modelProviderModel; Review Comment: Actually, Sink doesn't have similar logic. You can take a look at `LogicalSink`. It's better we can introduce the `ModelProviderModel ` if it provides some necessary utils. ########## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/calcite/RexModelCall.java: ########## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.planner.calcite; + +import org.apache.flink.table.planner.plan.schema.ModelProviderModel; + +import org.apache.calcite.rel.type.RelDataType; +import org.apache.calcite.rex.RexCall; +import org.apache.calcite.sql.SqlKind; +import org.apache.calcite.sql.SqlSpecialOperator; + +import java.util.List; + +/** + * A {@link RexCall} that represents a call to a model provider model. + * + * <p>This is used to represent calls to models in the Flink SQL planner. + */ +public class RexModelCall extends RexCall { Review Comment: I think the unfinished PR helps us to check the logic here. Do you mind move commits in the unfinished PR to here? So I can review all these details together. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
