aws-nageshvh commented on code in PR #208:
URL:
https://github.com/apache/flink-connector-aws/pull/208#discussion_r2098918137
##########
flink-connector-aws/flink-connector-aws-kinesis-streams/src/main/java/org/apache/flink/connector/kinesis/source/reader/fanout/FanOutKinesisShardSubscription.java:
##########
@@ -334,4 +368,87 @@ public void onComplete() {
activateSubscription();
}
}
+
+ /**
+ * Submits an event processing task to the executor service.
+ * This method encapsulates the task submission logic and error handling.
+ *
+ * @param event The subscription event to process
+ */
+ private void submitEventProcessingTask(SubscribeToShardEvent event) {
+ try {
+ subscriptionEventProcessingExecutor.execute(() -> {
+ synchronized (subscriptionEventProcessingLock) {
Review Comment:
yes, in the initial iteration when I was testing things out, I had made the
lock granular but decided against it. We don't need the lock object anymore.
Made the method synchronized
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
