vsantwana commented on code in PR #978:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/978#discussion_r2098281439
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/observer/JobStatusObserver.java:
##########
@@ -69,17 +75,23 @@ public boolean observe(FlinkResourceContext<R> ctx) {
var jobStatus = resource.getStatus().getJobStatus();
LOG.debug("Observing job status");
var previousJobStatus = jobStatus.getState();
-
+ var jobId = jobStatus.getJobId();
try {
var newJobStatusOpt =
ctx.getFlinkService()
- .getJobStatus(
- ctx.getObserveConfig(),
- JobID.fromHexString(jobStatus.getJobId()));
+ .getJobStatus(ctx.getObserveConfig(),
JobID.fromHexString(jobId));
if (newJobStatusOpt.isPresent()) {
- updateJobStatus(ctx, newJobStatusOpt.get());
+ var newJobStatus = newJobStatusOpt.get();
+ updateJobStatus(ctx, newJobStatus);
ReconciliationUtils.checkAndUpdateStableSpec(resource.getStatus());
+ // now check if the job is in a terminal state. This might not
be need as we have
+ // already
+ // verified that the REST API server is available
+ // now check if the job is NOT in a terminal state
+ if (!newJobStatus.getJobState().isGloballyTerminalState()) {
+ observeJobManagerExceptions(ctx);
+ }
Review Comment:
But if the current status (i.e the newStatus) is in terminal state, the API
server won't be available right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
