davidradl commented on code in PR #110:
URL:
https://github.com/apache/flink-connector-kafka/pull/110#discussion_r2096113219
##########
flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaSinkBuilder.java:
##########
@@ -61,7 +61,7 @@
public class KafkaSinkBuilder<IN> {
private static final Logger LOG =
LoggerFactory.getLogger(KafkaSinkBuilder.class);
- private static final Duration DEFAULT_KAFKA_TRANSACTION_TIMEOUT =
Duration.ofHours(1);
+ private static final Duration DEFAULT_KAFKA_TRANSACTION_TIMEOUT =
Duration.ofMinutes(15);
Review Comment:
It seems a reasonable change, but I am concerned about changing the default
of an option. The cautious approach would be to introduce a new parameter with
the new default, so the user can choose when to move to the new default and
there are no unexpected changes in behaviour for minor upgrades.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
