davidradl commented on code in PR #26576:
URL: https://github.com/apache/flink/pull/26576#discussion_r2095795160


##########
flink-filesystems/flink-s3-fs-base/src/main/java/org/apache/flink/fs/s3/common/FlinkS3FileSystem.java:
##########
@@ -81,7 +81,7 @@ public class FlinkS3FileSystem extends HadoopFileSystem
         implements EntropyInjectingFileSystem, PathsCopyingFileSystem {
     private static final Logger LOG = 
LoggerFactory.getLogger(FlinkS3FileSystem.class);
 
-    private static final long PROCESS_KILL_SLEEP_TIME_MS = 50L;
+    private static final long PROCESS_KILL_SLEEP_TIME_MS = 1000L;

Review Comment:
   I see 
[https://flink.apache.org/how-to-contribute/contribute-code/](https://flink.apache.org/how-to-contribute/contribute-code/)
 says hotfix is "Note: trivial hot fixes such as typos or syntax errors can be 
opened as a [hotfix] pull request, without a Jira ticket."
   
   I do not think this is that trivial. I suggest raising a Jira to indicate 
what problem you are looking to fix. 
   
   Please could you add a comment to say why you are increasing this sleep time 
by 20 times. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to