lvyanquan commented on code in PR #4014:
URL: https://github.com/apache/flink-cdc/pull/4014#discussion_r2095516157
##########
flink-cdc-connect/flink-cdc-source-connectors/flink-connector-sqlserver-cdc/src/main/java/org/apache/flink/cdc/connectors/sqlserver/source/utils/SqlServerUtils.java:
##########
@@ -361,12 +361,16 @@ private static String quoteSchemaAndTable(TableId
tableId) {
return quoted.toString();
}
- public static String quote(String dbOrTableName) {
- return "[" + dbOrTableName + "]";
+ /**
+ * @link <a
+ *
href="https://learn.microsoft.com/en-us/sql/t-sql/functions/quotename-transact-sql";>QUOTENAME</a>
+ */
+ public static String quote(String name) {
+ return "[" + name.replace("]", "]]") + "]";
Review Comment:
It's better to verify this change in testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
