yuxiqian commented on code in PR #3994:
URL: https://github.com/apache/flink-cdc/pull/3994#discussion_r2078940346
##########
flink-cdc-common/src/main/java/org/apache/flink/cdc/common/schema/Selectors.java:
##########
@@ -29,8 +33,16 @@
/** Selectors for filtering tables. */
public class Selectors {
+ private static final Duration CACHE_EXPIRE_DURATION = Duration.ofHours(1);
+
private List<Selector> selectors;
+ private final Cache<TableId, Boolean> cache =
+ CacheBuilder.newBuilder()
+ .expireAfterAccess(CACHE_EXPIRE_DURATION)
+ .maximumSize(1024)
+ .build();
Review Comment:
Is it correct to share this cache among all `Selector`s? IIUC it depends on
the effective `Selector` to determine if a `TableId` should be matched.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
