gyfora commented on code in PR #26521:
URL: https://github.com/apache/flink/pull/26521#discussion_r2077484613
##########
flink-libraries/flink-state-processing-api/src/main/java/org/apache/flink/state/table/SavepointConnectorOptions.java:
##########
@@ -35,6 +35,7 @@ public class SavepointConnectorOptions {
public static final String STATE_TYPE = "state-type";
public static final String MAP_KEY_FORMAT = "map-key-format";
Review Comment:
We should deprecate and rename this config to `key-class`
##########
flink-libraries/flink-state-processing-api/src/main/java/org/apache/flink/state/table/SavepointConnectorOptions.java:
##########
@@ -35,6 +35,7 @@ public class SavepointConnectorOptions {
public static final String STATE_TYPE = "state-type";
public static final String MAP_KEY_FORMAT = "map-key-format";
public static final String VALUE_FORMAT = "value-format";
Review Comment:
We should deprecate and rename this config to `value-class`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
