davidradl commented on code in PR #160:
URL:
https://github.com/apache/flink-connector-jdbc/pull/160#discussion_r2077305595
##########
flink-connector-jdbc-core/src/main/java/org/apache/flink/connector/jdbc/core/table/source/JdbcDynamicTableSource.java:
##########
@@ -179,7 +179,7 @@ public ScanRuntimeProvider
getScanRuntimeProvider(ScanContext runtimeProviderCon
}
if (limit >= 0) {
- query = String.format("%s %s", query,
dialect.getLimitClause(limit));
+ query = dialect.addLimitClause(query, limit);
Review Comment:
I find it confusing that we have a `getLimitClause` and an `addLimitClause`.
Why did we not just extend the getLimitClause to include the query and limit
as parameters. Then the dialect can return the limit clause as it likes . And
change this calling line to:
`query = dialect.getLimitClause(query, limit));`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
