tweise commented on code in PR #977:
URL: 
https://github.com/apache/flink-kubernetes-operator/pull/977#discussion_r2072719941


##########
helm/flink-kubernetes-operator/values.yaml:
##########
@@ -190,6 +195,7 @@ fullnameOverride: ""
 jvmArgs:
   webhook: ""
   operator: ""
+  operatorLog: 
"-Dlog4j.configurationFile=/opt/flink/conf/log4j-operator.properties"

Review Comment:
   entry point simply combines them for both operator and webhook: `$LOG_CONFIG 
$JVM_ARGS`
   
   however moving the log default to jvmArgs.operator and jvmArgs.webhook would 
introduce duplication and not be compatible with existing usage of those 
settings (log settings would be lost for everyone that uses jvmArgs currently.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to