davidradl commented on code in PR #26522:
URL: https://github.com/apache/flink/pull/26522#discussion_r2070440644


##########
flink-formats/flink-json/src/test/java/org/apache/flink/formats/json/JsonFormatFactoryTest.java:
##########
@@ -125,6 +125,51 @@ void testLowerCaseOptionForMapNullKeyMode() {
         testSchemaDeserializationSchema(tableOptions);
     }
 
+    @Test
+    void testDecodeJsonParseEnabled() {
+        // test enabled
+        final Map<String, String> enabledParseTableOptions =
+                getModifyOptions(options -> 
options.put("json.decode.json-parser.enabled", "true"));
+
+        DeserializationSchema<RowData> actualEnabledParseDeser =

Review Comment:
   it looks like the code repeated. I suggest. parameterized test passing in 
the 2 boolean values.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to