darenwkt opened a new pull request, #205: URL: https://github.com/apache/flink-connector-aws/pull/205
<!-- *Thank you for contributing to Apache Flink AWS Connectors - we are happy that you want to help us improve our Flink connectors. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.* ## Contribution Checklist - The name of the pull request should correspond to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue. - Commits should be in the form of "[FLINK-XXXX][component] Title of the pull request", where [FLINK-XXXX] should be replaced by the actual issue number. Generally, [component] should be the connector you are working on. For example: "[FLINK-XXXX][Connectors/Kinesis] XXXX" if you are working on the Kinesis connector or "[FLINK-XXXX][Connectors/AWS] XXXX" if you are working on components shared among all the connectors. - Each pull request should only have one JIRA issue. - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below. --> ## Purpose of the change Go through all the META-INF/NOTICE files and verify there are no missing dependencies: - Ran `mvn dependency:tree -Dscope=compile` to get a list of all dependencies - Narrow down the list by cross-checking POM file against which dependencies are actually included in shaded jar - Ran `jar -tf` to view content of jar to verify there are no missing dependencies as sanity check ### flink-sql-connector-dynamodb - sorted dependency list - shaded org.apache.commons ### flink-sql-connector-aws-kinesis-streams - sorted dependency list - updated POM to remove inclusion of `com.typesafe.netty:*` as it is not bundled in shaded jar ### flink-sql-connector-aws-kinesis-firehose - sorted dependency list - updated POM to remove inclusion of `com.typesafe.netty:*` as it is not bundled in shaded jar ### flink-sql-connector-kinesis - sorted dependency list ## Verifying this change This change is a trivial rework / code cleanup without any test coverage. ## Significant changes *(Please check any boxes [x] if the answer is "yes". You can first publish the PR and check them afterwards, for convenience.)* - [ ] Dependencies have been added or upgraded - [ ] Public API has been changed (Public API is any class annotated with `@Public(Evolving)`) - [ ] Serializers have been changed - [ ] New feature has been introduced - If yes, how is this documented? (not applicable / docs / JavaDocs / not documented) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
