pchoudhury22 commented on code in PR #966:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/966#discussion_r2068408578
##########
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/JobVertexScaler.java:
##########
@@ -178,6 +184,12 @@ public ParallelismChange computeScaleTargetParallelism(
LOG.debug("Target processing capacity for {} is {}", vertex,
targetCapacity);
double scaleFactor = targetCapacity / averageTrueProcessingRate;
+ if (conf.get(OBSERVED_SCALABILITY_ENABLED)) {
+ double scalingCoefficient =
+ JobVertexScaler.calculateObservedScalingCoefficient(
+ history,
conf.get(OBSERVED_SCALABILITY_MIN_OBSERVATIONS));
+ scaleFactor = scaleFactor / scalingCoefficient;
Review Comment:
Hi @gyfora , Good morning
Do we still need the above limit since we are clamping the lowerBound of
scaling coefficient to 0.5?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
