yuxiqian commented on PR #4007:
URL: https://github.com/apache/flink-cdc/pull/4007#issuecomment-2834555952
> > One potential breaking change is that since we're always returning a
cached version instead of calculating it every time, we have to make it
unmodifiable to avoid it from being changed accidentally. Any callers that need
the previous behavior must create a copy explicitly.
>
> As you have returned an immutable list, do we still need to worry about
the caller modifying it?
Yes, this could be prohibited by wrapping it with
`Collections.unmodifiableList`, but some client codes like
`schema.getColumnNames().add("...")` have to be changed to make a copy manually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
