eskabetxe commented on code in PR #162: URL: https://github.com/apache/flink-connector-jdbc/pull/162#discussion_r2059797560
########## flink-connector-jdbc-gaussdb/pom.xml: ########## @@ -0,0 +1,135 @@ +<?xml version="1.0" encoding="UTF-8"?> +<project xmlns="http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <modelVersion>4.0.0</modelVersion> + <parent> + <groupId>org.apache.flink</groupId> + <artifactId>flink-connector-jdbc-parent</artifactId> + <version>4.0-SNAPSHOT</version> + </parent> + + <artifactId>flink-connector-jdbc-gaussdb</artifactId> Review Comment: ou also need to integrate this module into the architecture module to ensure proper validation. ########## flink-connector-jdbc-gaussdb/pom.xml: ########## @@ -0,0 +1,135 @@ +<?xml version="1.0" encoding="UTF-8"?> +<project xmlns="http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <modelVersion>4.0.0</modelVersion> + <parent> + <groupId>org.apache.flink</groupId> + <artifactId>flink-connector-jdbc-parent</artifactId> + <version>4.0-SNAPSHOT</version> + </parent> + + <artifactId>flink-connector-jdbc-gaussdb</artifactId> Review Comment: you also need to integrate this module into the architecture module to ensure proper validation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
