xiangyuf commented on PR #26503: URL: https://github.com/apache/flink/pull/26503#issuecomment-2829228491
> @xiangyuf I am wondering what the migration implications are to change this to be default. In general it is not good practise to change defaults, but I see the flip has not being fully implemented so maybe this is not a concern. Please can you let me know your thinking; maybe this change in behaviour is always desirable and would not be seen as a break for existing users? Hi David, as discussed in this thread https://lists.apache.org/thread/r1wo9sf3d1725fhwzrttvv56k4rc782m, the sink reuse is enabled by default in the first place for following reason: "taking sink reuse as a long awaited feature with significant benefits for users, we choose to enable this in the first place. Similar features like `table.optimizer.reuse-sub-plan-enabled` and `table.optimizer.reuse-source-enabled` are also enabled by default. From this point of view, sink reuse should be the same." Also, this PR is a draft PR, I need to change several existing IT cases to pass the CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
