morozov commented on PR #3646:
URL: https://github.com/apache/flink-cdc/pull/3646#issuecomment-2828577003

   @lvyanquan on the one hand, it looks like 
https://github.com/apache/flink-cdc/pull/3812 itself could be used as a 
solution to my problem. In my PR, I'm trying to detect if the pipeline needs to 
run in the batch mode based on the source, while the PR you mentioned adds an 
explicit configuration to enable the batch mode. I could use explicit 
configuration and withdraw my PR.
   
   What I don't understand is, how schema change events are handled in the 
batch mode. I see that there is a new `BatchSchemaOperator` with the following 
code: 
https://github.com/apache/flink-cdc/blob/c2230d53a5732367d3776dda8b6b7c8a34f090a3/flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/operators/schema/regular/BatchSchemaOperator.java#L101-L115
   
   It looks like it will fail to process any other schema change event than 
`CreateTableEvent`. Won't it?
   
   Internally, I'm using the code changes from my other PR 
(https://github.com/apache/flink-cdc/pull/3999), and I'm trying to understand 
how this logic should apply to the batch schema operator.
   
   Could you clarify how the batch mode is meant to handle schema changes?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to