davidradl commented on code in PR #26492:
URL: https://github.com/apache/flink/pull/26492#discussion_r2056451530


##########
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/util/MetricUtils.java:
##########
@@ -338,6 +339,30 @@ static void instantiateMetaspaceMemoryMetrics(final 
MetricGroup parentMetricGrou
         }
     }
 
+    static void instantiateFileDescriptorMetrics(MetricGroup metrics) {
+        try {
+            final com.sun.management.OperatingSystemMXBean mxBean =
+                    (com.sun.management.OperatingSystemMXBean)
+                            ManagementFactory.getOperatingSystemMXBean();
+
+            if (mxBean instanceof 
com.sun.management.UnixOperatingSystemMXBean) {

Review Comment:
   If the class is not found then wouldn't `instanceof` fail ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to