darenwkt commented on code in PR #187: URL: https://github.com/apache/flink-connector-aws/pull/187#discussion_r2055397437
########## flink-connector-aws/flink-sql-connector-sqs/src/test/java/org/apache/flink/connector/sqs/PackagingITCase.java: ########## @@ -0,0 +1,30 @@ +package org.apache.flink.connector.sqs; + +import org.apache.flink.packaging.PackagingTestUtils; +import org.apache.flink.table.factories.Factory; +import org.apache.flink.test.resources.ResourceTestUtils; + +import org.junit.jupiter.api.Test; + +import java.nio.file.Path; +import java.util.Arrays; + +/** Packaging test for the SQS SQL connector. */ +public class PackagingITCase { + + @Test + void testPackaging() throws Exception { + final Path jar = ResourceTestUtils.getResource(".*/flink-sql-connector-sqs[^/]*\\.jar"); + + PackagingTestUtils.assertJarContainsOnlyFilesMatching( + jar, + Arrays.asList( + "org/apache/flink/", + "org/apache/commons/", Review Comment: Should we shade and relocate this to `org.apache.flink.connector.sqs.shaded` like the other dependencies? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org