lvyanquan commented on code in PR #3865:
URL: https://github.com/apache/flink-cdc/pull/3865#discussion_r2052368481
##########
flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/operators/transform/PreTransformOperator.java:
##########
@@ -411,18 +411,16 @@ private void cacheTransformRuleInfo(CreateTableEvent
createTableEvent) {
private CreateTableEvent transformCreateTableEvent(CreateTableEvent
createTableEvent) {
TableId tableId = createTableEvent.tableId();
- for (Tuple2<Selectors, SchemaMetadataTransform> transform :
schemaMetadataTransformers) {
- Selectors selectors = transform.f0;
- if (selectors.isMatch(tableId)) {
- createTableEvent =
- new CreateTableEvent(
- tableId,
- transformSchemaMetaData(
- createTableEvent.getSchema(),
transform.f1));
- }
- }
-
- cachePreTransformProcessor(tableId, createTableEvent.getSchema());
+ Schema originalSchema = createTableEvent.getSchema();
+ LinkedHashSet<Schema> newSchemas =
+ schemaMetadataTransformers.stream()
+ .filter(transform -> transform.f0.isMatch(tableId))
+ .map(transform ->
transformSchemaMetaData(originalSchema, transform.f1))
+ .collect(Collectors.toCollection(LinkedHashSet::new));
+ SchemaUtils.validateMetaSchemaCompatibility(newSchemas);
Review Comment:
We should throw an exception to clearly indicate which two rules conflict
for which table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
