aiwenmo commented on code in PR #3812:
URL: https://github.com/apache/flink-cdc/pull/3812#discussion_r2051474586
##########
flink-cdc-common/src/main/java/org/apache/flink/cdc/common/factories/DataSourceFactory.java:
##########
@@ -28,4 +28,7 @@ public interface DataSourceFactory extends Factory {
/** Creates a {@link DataSource} instance. */
DataSource createDataSource(Context context);
+
+ /** Checking if this {@link DataSource} could be created in batch mode. */
+ default void verifyRuntimeMode(Context context) {}
Review Comment:
Hi. @leonardBang The purpose of adding this method is to remind developers
to handle streaming and batch processing when developing new data sources. It's
also feasible to remove the definition of this method and let developers
implement it themselves in the createDataSource method. So, should we remove it
now? I'm glad to hear your opinion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
