ruanhang1993 commented on code in PR #3976: URL: https://github.com/apache/flink-cdc/pull/3976#discussion_r2050238997
########## flink-cdc-connect/flink-cdc-source-connectors/flink-connector-debezium/src/main/java/io/debezium/relational/RelationalTableFilters.java: ########## @@ -0,0 +1,143 @@ +/* + * Copyright Debezium Authors. + * + * Licensed under the Apache Software License version 2.0, available at http://www.apache.org/licenses/LICENSE-2.0 + */ +package io.debezium.relational; + +import io.debezium.config.Configuration; +import io.debezium.relational.Selectors.TableIdToStringMapper; +import io.debezium.relational.Selectors.TableSelectionPredicateBuilder; +import io.debezium.relational.Tables.TableFilter; +import io.debezium.relational.history.DatabaseHistory; +import io.debezium.schema.DataCollectionFilters; + +import java.util.function.Predicate; + +import static io.debezium.relational.RelationalDatabaseConnectorConfig.COLUMN_BLACKLIST; +import static io.debezium.relational.RelationalDatabaseConnectorConfig.COLUMN_EXCLUDE_LIST; + +public class RelationalTableFilters implements DataCollectionFilters { Review Comment: Add java doc and describe where is changed. ########## flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/org/apache/flink/cdc/connectors/mysql/source/config/MySqlSourceConfig.java: ########## @@ -132,6 +133,18 @@ public class MySqlSourceConfig implements Serializable { this.dbzProperties = checkNotNull(dbzProperties); this.dbzConfiguration = Configuration.from(dbzProperties); this.dbzMySqlConfig = new MySqlConnectorConfig(dbzConfiguration); + Selectors excludeTableFilter = + (excludeTableList == null + ? null + : new Selectors.SelectorsBuilder().includeTables(excludeTableList).build()); + Tables.TableFilter tableFilter = dbzMySqlConfig.getTableFilters().dataCollectionFilter(); + dbzMySqlConfig + .getTableFilters() + .setDataCollectionFilters( + (TableId tableId) -> + tableFilter.isIncluded(tableId) + && (excludeTableFilter == null + || !excludeTableFilter.isMatch(tableId))); Review Comment: In mysql cdc connector, we need to disable to pass 'debezium.table.include.list' and 'debezium.table.exclude.list'. Please add some check and warning for these options. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
