SML0127 commented on PR #3928: URL: https://github.com/apache/flink-cdc/pull/3928#issuecomment-2812255665
Hi, @leonardBang @ruanhang1993 Sorry for the late check. I saw the under error in CI. ```d Caused by: org.apache.flink.table.api.ValidationException: Chunk key column 'name' doesn't exist in the columns [Id,Name,address,phone_number] of the table customer.Customers. ``` Among the engines that support incremental snapshots, I know of none that are case sensitive unless enclosed in double quotes. So what do you think about the following change in `JdbcChunkUtils.getSplitColumn`? AS-IS ```java List<Column> searchColumns = table.columns(); if (chunkKeyColumn != null) { Optional<Column> targetPkColumn = searchColumns.stream() .filter(col -> chunkKeyColumn.equals(col.name())) .findFirst(); ``` TO-BE ```java List<Column> searchColumns = table.columns(); if (chunkKeyColumn != null) { Optional<Column> targetPkColumn = searchColumns.stream() .filter(col -> chunkKeyColumn.equalsIgnoreCase(col.name())) // changed .findFirst(); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org