beliefer commented on code in PR #26469:
URL: https://github.com/apache/flink/pull/26469#discussion_r2046563202
##########
flink-runtime/src/main/java/org/apache/flink/streaming/runtime/tasks/mailbox/TaskMailbox.java:
##########
@@ -138,21 +144,23 @@ public interface TaskMailbox {
*
* @return true if there is at least one element in the batch; that is, if
there is any mail at
* all at the time of the invocation.
+ * @throws IllegalStateException if called from non-mailbox thread.
*/
boolean createBatch();
/**
- * Returns an optional with either the oldest mail from the batch (head of
queue) if the batch
+ * Returns an optional with either the oldest mail from the batch (head of
batch) if the batch
Review Comment:
`(head of queue)` -> `(head of batch)`. We only fetch the head mail from the
`batch` not the `queue` with `tryTakeFromBatch`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
