davidradl commented on code in PR #26438:
URL: https://github.com/apache/flink/pull/26438#discussion_r2039558922
##########
flink-table/flink-table-planner/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java:
##########
@@ -1051,6 +1051,14 @@ private SqlNode validateScopedExpression(SqlNode
topNode, SqlValidatorScope scop
if (outermostNode.isA(SqlKind.TOP_LEVEL)) {
registerQuery(scope, null, outermostNode, outermostNode, null,
false);
}
+ // ----- FLINK MODIFICATION BEGIN -----
+ if (outermostNode instanceof SqlSelect) {
+ SqlSelect select = (SqlSelect) outermostNode;
Review Comment:
I am not an expert on the table planner - but had some basic questions.
1) I am not seeing how we know it is a select * . Is this related to `if
(outermostNode instanceof SqlSelect) {`
2) Will this effect all `select *` code , include the working non UDF
`select *`'s? If so is there now redundant code we need to remove that dealt
with the * later?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
