[ 
https://issues.apache.org/jira/browse/FLINK-5348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15767433#comment-15767433
 ] 

ASF GitHub Bot commented on FLINK-5348:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3020#discussion_r93405538
  
    --- Diff: 
flink-core/src/test/java/org/apache/flink/api/java/typeutils/RowTypeInfoTest.java
 ---
    @@ -18,12 +18,86 @@
     package org.apache.flink.api.java.typeutils;
     
     import org.apache.flink.api.common.typeinfo.BasicTypeInfo;
    +import org.apache.flink.api.common.typeinfo.TypeInformation;
    +import org.apache.flink.api.common.typeutils.CompositeType;
    +import org.junit.BeforeClass;
     import org.junit.Test;
     
    +import java.util.ArrayList;
    +import java.util.Arrays;
    +import java.util.List;
    +
    +import static org.junit.Assert.assertArrayEquals;
     import static org.junit.Assert.assertEquals;
     import static org.junit.Assert.assertNotEquals;
    +import static org.junit.Assert.assertTrue;
    +import static org.junit.Assert.fail;
     
     public class RowTypeInfoTest {
    --- End diff --
    
    Add tests for `getFlatFields()`?


> Support custom field names for RowTypeInfo
> ------------------------------------------
>
>                 Key: FLINK-5348
>                 URL: https://issues.apache.org/jira/browse/FLINK-5348
>             Project: Flink
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Jark Wu
>            Assignee: Jark Wu
>
> Currently, the RowTypeInfo doesn't support optional custom field names, but 
> forced to generate {{f0}} ~ {{fn}} as field names. It would be better to 
> support custom names and will benefit some cases (e.g. FLINK-5280).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to