loserwang1024 commented on PR #3983:
URL: https://github.com/apache/flink-cdc/pull/3983#issuecomment-2792455779
> and the change code how to performance the logic ?
@Mrart this pr is mainly focused on most situations. We can improve it later
when newly added table.
To be honest, it's not a good idea for that a reader fequently switch from
streaming split and snapshot split（unless just 1 perrellism). The switch costs
a lot. I have too ideas:
1. the first idea: do not assign newly added snapshot split to the reader
which handling binlog. I will recently push forward a FLIP to let enumerator
knows currently split distributions.
2. the second idea: The splitReader can reading snapshot split and stream
split into a queue in the same time, is no need to just read one in a time. It
will need to change current thread model.
But this PR still can improve a lot, we can let it in at first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
