beliefer commented on code in PR #26426:
URL: https://github.com/apache/flink/pull/26426#discussion_r2036390683


##########
flink-core/src/main/java/org/apache/flink/configuration/Configuration.java:
##########
@@ -239,9 +239,21 @@ public void addAllToProperties(Properties props) {
     }
 
     public void addAll(Configuration other) {
-        synchronized (this.confData) {

Review Comment:
   This change makes we always lock one first and then another. As you said, 
one thread locks the other object, then all the threads will lock the other 
object first.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to