soisyourface opened a new pull request, #197:
URL: https://github.com/apache/flink-connector-aws/pull/197

   I am waiting for access to JIRA to create the issue but figured I'd create 
the PR to get the conversation started.
   There is a conversation in 
[slack](https://apache-flink.slack.com/archives/C03G7LJTS2G/p1743713205172909) 
that has some additional information.
   ## Purpose of the change
   
   SSO Credentials do not work without including the `sso` and `ssooidc` 
dependencies in the shaded jar.
   
   ## Verifying this change
   I've tested this locally by doing `mvn clean install` and then using 
`5.1-SNAPSHOT` in my flink job. I can add further tests if this PR is wanted.
   
   Please make sure both new and modified tests in this PR follows the 
conventions defined in our code quality guide: 
https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
   
   *(Please pick either of the following options)*
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This change is already covered by existing tests, such as *(please describe 
tests)*.
   
   *(or)*
   
   This change added tests and can be verified as follows:
   
   *(example:)*
   - *Added integration tests for end-to-end deployment*
   - *Added unit tests*
   - *Manually verified by running the Kinesis connector on a local Flink 
cluster.*
   
   ## Significant changes
   *(Please check any boxes [x] if the answer is "yes". You can first publish 
the PR and check them afterwards, for convenience.)*
   - [ ] Dependencies have been added or upgraded
   - [ ] Public API has been changed (Public API is any class annotated with 
`@Public(Evolving)`)
   - [ ] Serializers have been changed
   - [ ] New feature has been introduced
     - If yes, how is this documented? (not applicable / docs / JavaDocs / not 
documented)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to