Zakelly commented on code in PR #25837: URL: https://github.com/apache/flink/pull/25837#discussion_r2034388628
########## flink-runtime/src/main/java/org/apache/flink/runtime/state/metrics/MetricsTrackingListState.java: ########## @@ -0,0 +1,270 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.state.metrics; + +import org.apache.flink.api.common.typeutils.TypeSerializer; +import org.apache.flink.api.common.typeutils.base.ListSerializer; +import org.apache.flink.metrics.MetricGroup; +import org.apache.flink.runtime.state.KeyedStateBackend; +import org.apache.flink.runtime.state.internal.InternalListState; + +import java.io.IOException; +import java.util.Collection; +import java.util.Collections; +import java.util.List; + +/** + * This class wraps list state with latency tracking logic. + * + * @param <K> The type of key the state is associated to + * @param <N> The type of the namespace + * @param <T> Type of the user entry value of state + */ +class MetricsTrackingListState<K, N, T> + extends AbstractMetricsTrackState< + K, + N, + List<T>, + InternalListState<K, N, T>, + MetricsTrackingListState.ListStateMetrics> + implements InternalListState<K, N, T> { + + private TypeSerializer<T> elementSerializer; + + MetricsTrackingListState( + String stateName, + InternalListState<K, N, T> original, + KeyedStateBackend<K> keyedStateBackend, + LatencyTrackingStateConfig latencyTrackingStateConfig, + SizeTrackingStateConfig sizeTrackingStateConfig) { + super( + original, + keyedStateBackend, + latencyTrackingStateConfig.isEnabled() + ? new ListStateMetrics( + stateName, + latencyTrackingStateConfig.getMetricGroup(), + latencyTrackingStateConfig.getSampleInterval(), + latencyTrackingStateConfig.getHistorySize(), + latencyTrackingStateConfig.isStateNameAsVariable()) + : null, + sizeTrackingStateConfig.isEnabled() + ? new ListStateMetrics( + stateName, + sizeTrackingStateConfig.getMetricGroup(), + sizeTrackingStateConfig.getSampleInterval(), + sizeTrackingStateConfig.getHistorySize(), + sizeTrackingStateConfig.isStateNameAsVariable()) + : null); + if (valueSerializer != null) { + this.elementSerializer = + ((ListSerializer<T>) this.valueSerializer).getElementSerializer().duplicate(); + } + } + + @Override + public Iterable<T> get() throws Exception { + if (sizeTrackingStateMetric != null && sizeTrackingStateMetric.trackMetricsOnGet()) { + sizeTrackingStateMetric.updateMetrics( + ListStateMetrics.LIST_STATE_GET_KEY_SIZE, super.sizeOfKey()); + sizeTrackingStateMetric.updateMetrics( + ListStateMetrics.LIST_STATE_GET_VALUE_SIZE, sizeOfValueList(original.get())); Review Comment: Seems will get twice when enabling size tracking. How about only optimize this to only get once? ########## flink-runtime/src/main/java/org/apache/flink/runtime/state/metrics/MetricsTrackingListState.java: ########## @@ -0,0 +1,270 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.state.metrics; + +import org.apache.flink.api.common.typeutils.TypeSerializer; +import org.apache.flink.api.common.typeutils.base.ListSerializer; +import org.apache.flink.metrics.MetricGroup; +import org.apache.flink.runtime.state.KeyedStateBackend; +import org.apache.flink.runtime.state.internal.InternalListState; + +import java.io.IOException; +import java.util.Collection; +import java.util.Collections; +import java.util.List; + +/** + * This class wraps list state with latency tracking logic. + * + * @param <K> The type of key the state is associated to + * @param <N> The type of the namespace + * @param <T> Type of the user entry value of state + */ +class MetricsTrackingListState<K, N, T> + extends AbstractMetricsTrackState< + K, + N, + List<T>, + InternalListState<K, N, T>, + MetricsTrackingListState.ListStateMetrics> + implements InternalListState<K, N, T> { + + private TypeSerializer<T> elementSerializer; + + MetricsTrackingListState( + String stateName, + InternalListState<K, N, T> original, + KeyedStateBackend<K> keyedStateBackend, + LatencyTrackingStateConfig latencyTrackingStateConfig, + SizeTrackingStateConfig sizeTrackingStateConfig) { + super( + original, + keyedStateBackend, + latencyTrackingStateConfig.isEnabled() + ? new ListStateMetrics( + stateName, + latencyTrackingStateConfig.getMetricGroup(), + latencyTrackingStateConfig.getSampleInterval(), + latencyTrackingStateConfig.getHistorySize(), + latencyTrackingStateConfig.isStateNameAsVariable()) + : null, + sizeTrackingStateConfig.isEnabled() + ? new ListStateMetrics( + stateName, + sizeTrackingStateConfig.getMetricGroup(), + sizeTrackingStateConfig.getSampleInterval(), + sizeTrackingStateConfig.getHistorySize(), + sizeTrackingStateConfig.isStateNameAsVariable()) + : null); + if (valueSerializer != null) { + this.elementSerializer = + ((ListSerializer<T>) this.valueSerializer).getElementSerializer().duplicate(); + } + } + + @Override + public Iterable<T> get() throws Exception { + if (sizeTrackingStateMetric != null && sizeTrackingStateMetric.trackMetricsOnGet()) { + sizeTrackingStateMetric.updateMetrics( + ListStateMetrics.LIST_STATE_GET_KEY_SIZE, super.sizeOfKey()); + sizeTrackingStateMetric.updateMetrics( + ListStateMetrics.LIST_STATE_GET_VALUE_SIZE, sizeOfValueList(original.get())); Review Comment: Same for other states ########## flink-runtime/src/main/java/org/apache/flink/runtime/state/metrics/MetricsTrackingAggregatingState.java: ########## @@ -89,26 +110,29 @@ public void updateInternal(ACC valueToStore) throws Exception { @Override public void mergeNamespaces(N target, Collection<N> sources) throws Exception { - if (latencyTrackingStateMetric.trackLatencyOnMergeNamespace()) { + if (latencyTrackingStateMetric != null + && latencyTrackingStateMetric.trackMetricsOnMergeNamespace()) { trackLatencyWithException( () -> original.mergeNamespaces(target, sources), - AggregatingStateLatencyMetrics.AGGREGATING_STATE_MERGE_NAMESPACES_LATENCY); + AggregatingStateMetrics.AGGREGATING_STATE_MERGE_NAMESPACES_LATENCY); } else { original.mergeNamespaces(target, sources); } } - static class AggregatingStateLatencyMetrics extends StateLatencyMetricBase { + static class AggregatingStateMetrics extends StateMetricBase { private static final String AGGREGATING_STATE_GET_LATENCY = "aggregatingStateGetLatency"; private static final String AGGREGATING_STATE_ADD_LATENCY = "aggregatingStateAddLatency"; private static final String AGGREGATING_STATE_MERGE_NAMESPACES_LATENCY = "aggregatingStateMergeNamespacesLatency"; + private static final String AGGREGATING_STATE_GET_KEY_SIZE = "aggregatingStateGetKeySize"; + private static final String AGGREGATING_STATE_ADD_KEY_SIZE = "aggregatingStateAddKeySize"; Review Comment: So why we are not tracking value size in aggregating state? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
