davidradl commented on code in PR #26378:
URL: https://github.com/apache/flink/pull/26378#discussion_r2021354308


##########
docs/content/docs/dev/table/sql-gateway/overview.md:
##########
@@ -84,6 +84,14 @@ $ curl --request POST 
http://localhost:8083/v1/sessions/${sessionHandle}/stateme
 
 The `operationHandle` in the return results is used by the SQL Gateway to 
uniquely identify the submitted SQL.
 
+The Flink SQL Gateway allows clients to specify which Flink cluster to submit 
jobs to, enabling remote execution of SQL statements and facilitating easier 
interaction with Flink clusters through a REST API. Enrich the POST request 
body with `executionConfig` variable to set the Flink cluster address. For 
example:

Review Comment:
   Is the executionConfig 
[this](https://nightlies.apache.org/flink/flink-docs-release-2.0/docs/dev/datastream/execution/execution_configuration/)
 if so shouldn't  this parameter be documented there? Can the other parts of 
the  executionConfig be specified on the rest call? Or is this a different 
executionConfig? We should document what the defaults are for the 
ExecutionContext and its parameters?
   
   Also we should mention in the text why/when you would want to specify a 
non-default jm endpoint for the gateway. 
    
   I think the parameters in the example should be parameterized i.e. {port} 
and then explain what port is. As is I support port will fail as it is not a 
number.
   @ammu20-dev 
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to