dawidwys commented on code in PR #26389:
URL: https://github.com/apache/flink/pull/26389#discussion_r2032821467


##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/QueryOperation.java:
##########
@@ -40,10 +41,12 @@ public interface QueryOperation extends Operation {
      * Returns a string that fully serializes this instance. The serialized 
string can be used for
      * storing the query in e.g. a {@link 
org.apache.flink.table.catalog.Catalog} as a view.
      *
+     * @param context can be used to customize the serialization to a SQL 
string
      * @return detailed string for persisting in a catalog
      * @see Operation#asSummaryString()
+     * @see 
EnvironmentSettings.Builder#withSerializationContext(SerializationContext)
      */
-    default String asSerializableString() {
+    default String asSerializableString(SerializationContext context) {

Review Comment:
   Yes, I did it for `ResolvedExpression` but missed it here, sorry.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to