snuyanzin commented on code in PR #26385:
URL: https://github.com/apache/flink/pull/26385#discussion_r2031904769
##########
flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/catalog/CatalogManagerTest.java:
##########
@@ -343,12 +343,14 @@ public void testModelModificationListener() throws
Exception {
assertThat(alterEvent.ignoreIfNotExists()).isFalse();
// Drop a model
- catalogManager.dropModel(
- ObjectIdentifier.of(
- catalogManager.getCurrentCatalog(),
- catalogManager.getCurrentDatabase(),
- "model1"),
- true);
+ assertThat(
+ catalogManager.dropModel(
+ ObjectIdentifier.of(
+ catalogManager.getCurrentCatalog(),
+ catalogManager.getCurrentDatabase(),
+ "model1"),
Review Comment:
We can extract `ObjectIdentifier` into a variable to avoid formatting issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
