fredia commented on PR #26412: URL: https://github.com/apache/flink/pull/26412#issuecomment-2783112395
> Should we also use ResourceGuard like [FLINK-37597](https://issues.apache.org/jira/browse/FLINK-37597) when using sync mode to access remote storage ? `ResourceGuard` is used to ensure that the snapshot threads are completed before `ForStSyncKeyedStateBackend` disposing, and `ForStSyncKeyedStateBackend#dispose()` has already achieved this. IIUC, the remote storage accessing in `ForStSyncKeyedStateBackend` is done in the main task thread, maybe extra work is not necessary, correct me if I'm wrong :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
