pnowojski commented on code in PR #26388:
URL: https://github.com/apache/flink/pull/26388#discussion_r2030767818
##########
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/InternalSourceSplitMetricGroup.java:
##########
@@ -191,4 +191,17 @@ public Boolean isIdle() {
public Boolean isActive() {
return !isPaused() && !isIdle();
}
+
+ public void onSplitFinished() {
+ if (splitWatermarkMetricGroup instanceof AbstractMetricGroup) {
+ ((AbstractMetricGroup) splitWatermarkMetricGroup).close();
+ } else {
+ LOG.warn("Split watermark metric group can not be closed");
Review Comment:
nit: log what's the instance type of the metric group?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
